util.ImmutableValidatedObject: Support Optional[ImmutableValidatedObject] #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rehno-lindeque force-pushed the immutable-validated-object-optional branch from 46ea7c9 to fdfbd13 Compare 
rehno-lindeque commented Nov 5, 2021
Comment on lines +170 to +177
| # Support Sequence[ImmutableValidatedObject] | ||
| if isinstance(value, Sequence) and issubclass(tuple, type_origin): | ||
| value = tuple(_transform_value(v, type_args[0]) for v in value) | ||
| | ||
| # Support Optional[ImmutableValidatedObject] | ||
| if type_origin is Union: | ||
| if value is not None: | ||
| value = _transform_value(value, type_args[0]) |
Author
There was a problem hiding this comment.
I discovered that the logic for this is slightly off, so hold off reviewing for now please.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Similar to 88494fb this adds support for
Optional[ImmutableValidatedObject]Usage
E.g. this is not currently possible:
Considerations
Supporting additional generic types
It's trivial to add support for
Mapping[Any, ImmutableValidatedObject]as well, but I didn't want to add new code that isn't actively used in a plugin.Satisfying mypy
Mypy needs to be upgraded to remove
type: ignore[attr-defined]aftertyping.get_argsandtyping.get_origin.Never-the-less the tests pass just fine with this version of python: