Distribution.Nixpkgs.Haskell.FromCabal: no longer emit dep on webkitgtk24x #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
webkitgtk24x-gtk{2,3} have been removed from nixpkgs a while ago and only continue to exist as aliases which throw, informing about the removal. This is informative, but depends on evaluating with aliases enabled which may not always be the case. Instead we just remove this now essentially useless code from cabal2nix. This will usually cause a dependency on the current version of webkitgtk and the build to fail -- then we can mark the resulting package as broken normally which was prevented before by eval oddities (I presume at least). 
sternenseemann force-pushed the no-more-webkitgtk24 branch from dabe9de to fb8fd9d Compare This reflects nixpkgs where webkit is an alias for webkitgtk.
maralorn approved these changes Sep 28, 2021
Member
maralorn left a comment
maralorn left a comment There was a problem hiding this comment.
Looks very reasonable.
But maybe this should warrant a CHANGELOG entry and a major version bump? Not sure …
Member Author
| We will do a major version bump anyways and a changelog entry never hurts, you're right. Care to proofread? |
Member
| Great! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
webkitgtk24x-gtk{2,3} have been removed from nixpkgs a while ago and
only continue to exist as aliases which throw, informing about the
removal. This is informative, but depends on evaluating with aliases
enabled which may not always be the case.
Instead we just remove this now essentially useless code from
cabal2nix. This will usually cause a dependency on the current version
of webkitgtk and the build to fail -- then we can mark the resulting
package as broken normally which was prevented before by eval
oddities (I presume at least).