Include data key when lazy-loaded relationships are included #425
+177 −37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Release 1.5
Some part of the documentation for this got removed during last merge, so fixing it.
* Test against Ruby 2.6 * Enforce bundler 1.17.3
* Allow relationship links to be declared as object method * Relationship links note added to readme
* The link was already there but I skipped over it on my first read. This update makes the fact more prominent. * I was testing to see if we wanted to move from AM Serializers to fast_jsonapi but our API is not written according to the JSON:API spec so, after converting one serializer over, I learned that this would not work for me. * This update might save someone in my position the ~30 mins or so it takes to bundle and write a serializer in the future. :)
Fix typo
* Test against Ruby 2.6 * Enforce bundler 1.17.3
* Allow relationship links to be declared as object method * Relationship links note added to readme
| up |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #357
When a relationship is listed under
include:, it will add the data key to the record hash, allowing the included relationships to be reconstructed.