sync with upstream #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mozilla-services#3745) This adds a string property "thread_name" to thread stacks output by stackwalker. The thread names are parsed from the crash annotation "ThreadIdNameMapping", which is the concatination of: thread_id:"thread name", Example: 6106:"Timer",6108:"Link Monitor",6109:"Socket Thread",
…g symbols via HTTP (mozilla-services#3775) This will allow the symbol server to store the info necessary for missing symbols so we can fetch them from the Microsoft symbol server.
…llSourceLineInfo When Breakpad was updated to the most recent snapshot the signature of this method in the base class changed, but we didn't update our implementation to match, so our overload was not being called.
Some crash reports cause minidump-stackwalk to kick up a std::out_of_range error when trying to figure out the cpu microcode by converting a string to an int. The value that's causing problems is 0xffffffff. Gabriele says the firmware holds a 32-bit unsigned int, so stoi isn't going to work. This fixes the problem by changing the code from `stoi` to `stoul` per his suggestion.
There are some crash reports where the module in the frame is empty. This was causing the assertion to fail. Instead of asserting it's not empyt, we can convert it to an "if" block and add the module to the frame information only if it's there like we do with some other things. This works with the rest of the processing pipeline and the webapp report view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.