fix: avoid generating invalid JavaScript when merging IIFE files #965

DimitarTachev · 2019-07-04T08:50:21Z

Bonus: the snapshot tool is now logging the real JS error.

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

Related to: #920

… file script

DimitarTachev · 2019-07-04T10:16:29Z

test package_version#rc

DimitarTachev · 2019-07-04T12:39:34Z

test --ignore

DimitarTachev added 2 commits July 4, 2019 11:42

fix: avoid generating invalid JavaScript when merging IIFE files

7586d4c

fix: log the real snapshot tool error by trying to evaluate the input…

1a9c4b2

… file script

cla-bot bot added the cla: yes label Jul 4, 2019

Fatme approved these changes Jul 4, 2019

View reviewed changes

DimitarTachev merged commit 994d6a2 into release Jul 5, 2019

DimitarTachev deleted the tachev/fix-uglfiy-sourcemaps-snapshot branch July 5, 2019 05:48