Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Conversation

@rosen-vladimirov
Copy link
Contributor

The lazy-ngmodule-hot-loader breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with --bundle in VSCode extension as the files included in the sourcesContent cannot be mapped correctly to local files.

PR Checklist

What is the current behavior?

  • Unable to debug Angular projects in VSCode.
  • When debugging Angular projects in Chrome DevTools, the content of the files under webpack is not the same as your actual content - it's not TypeScript anymore:
    webpack_incorrect_sources

What is the new behavior?

  • You can debug Angular projects in VSCode
  • Sources under webpack in Chrome DevTools are correct

Fixes issue nativescript-community/nativescript-vscode-extension#232

The `lazy-ngmodule-hot-loader` breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with `--bundle` in VSCode extension as the files included in the `sourcesContent` cannot be mapped correctly to local files.
@rosen-vladimirov rosen-vladimirov merged commit 5ab0466 into release Jan 28, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-lazy-loading-loader-release branch January 28, 2019 07:40
@SvetoslavTsenov SvetoslavTsenov restored the vladimirov/fix-lazy-loading-loader-release branch January 28, 2019 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants