This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix(Vue): apply style changes with HMR #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
KristianDD reviewed Jan 7, 2019
The `bundle-config-loader` executes for `entryPath` with all extensions: `css`, `js`, `ts`, `scss`, etc. Limit only to `js` and `ts`. Fixes #762.
vchimev force-pushed the vchimev/vue-hmr-styles branch from 2dc81e1 to 0f13b0e Compare vchimev force-pushed the vchimev/vue-hmr-styles branch from 0f13b0e to 0d65b2b Compare 
vakrilov approved these changes Jan 14, 2019
Contributor
| The reverted commit was fixing #742. The problem was reproducible only on Windows. |
SvetoslavTsenov pushed a commit that referenced this pull request Jan 28, 2019
* fix(Vue): apply style changes with HMR The `bundle-config-loader` executes for `entryPath` with all extensions: `css`, `js`, `ts`, `scss`, etc. Limit only to `js` and `ts`. Fixes #762. * Revert "fix(Vue): resolve full path for entry module (#744)" This reverts commit 4d31ea0. It causes #762. * fix(Vue): entry module path Fixes #742, fixes #762.
SvetoslavTsenov added a commit that referenced this pull request Jan 28, 2019
* fix(Vue): apply style changes with HMR The `bundle-config-loader` executes for `entryPath` with all extensions: `css`, `js`, `ts`, `scss`, etc. Limit only to `js` and `ts`. Fixes #762. * Revert "fix(Vue): resolve full path for entry module (#744)" This reverts commit 4d31ea0. It causes #762. * fix(Vue): entry module path Fixes #742, fixes #762.
SvetoslavTsenov added a commit that referenced this pull request Jan 28, 2019
* fix(Vue): apply style changes with HMR (#763) * fix(Vue): apply style changes with HMR The `bundle-config-loader` executes for `entryPath` with all extensions: `css`, `js`, `ts`, `scss`, etc. Limit only to `js` and `ts`. Fixes #762. * Revert "fix(Vue): resolve full path for entry module (#744)" This reverts commit 4d31ea0. It causes #762. * fix(Vue): entry module path Fixes #742, fixes #762. * Release 0.19.0 (#757) * fix: lazy-ngmodule-hot-loader breaks the sourceMaps The `lazy-ngmodule-hot-loader` breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with `--bundle` in VSCode extension as the files included in the `sourcesContent` cannot be mapped correctly to local files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The
bundle-config-loaderexecutes forentryPathwith all extensions:css,js,ts,scss, etc.What is the new behavior?
The
bundle-config-loaderexecutes only forentryPathwithjsortsextensions.Fixes #762.