This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix-next(Angular): HMR for lazy loaded NgModules #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vchimev force-pushed the vchimev/fix-lazy-hmr branch from cb4d6be to de6ba3b Compare 
sis0k0 approved these changes Jan 4, 2019
sis0k0 reviewed Jan 4, 2019
vchimev commented Jan 4, 2019
Co-Authored-By: vchimev <vasil.chimev@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, the
lazy-ngmodule-hot-loaderadds a HMR self-accept to every lazy loaded NgModule during a build.What is the new behavior?
After alignment of the HMR lifecycle of NativeScript Angular with non-Angular applications, it requires a handler to update the app after module replacement.