Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Conversation

@sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jul 3, 2018

Revert to adding @ngtools/webpack instead of
@angular-devkit/build-angular because the later is ~150mb bigger and
slows down the {N} cloud builds.
Add @ngtools/webpack to the project dependencies only if
@angular-devkit/build-angular isn't there already. That's because the
@angular-devkit/build-angular already depends on @ngtools/webpack. This will prevent the
plugin from adding multiple instances of @ngtools/webpack to the project
which would cause the build to fail.

related to #571, #569

BREAKING CHANGES

Not really a breaking change but:
It's a good idea to remove the @angular-devkit/build-angular from the
package.json and add @ngtools/webpack instead as this will speed up
the build.

fixes #595

@sis0k0 sis0k0 self-assigned this Jul 3, 2018
@sis0k0 sis0k0 force-pushed the sis0k0/revert-build-angular-add branch from 2664884 to aa1a08d Compare July 3, 2018 17:08
@angular-devkit/build-angular is not a dependency Revert to adding @ngtools/webpack instead of @angular-devkit/build-angular because the later is ~150mb bigger and slows down the {N} cloud builds. Add @ngtools/webpack to the project dependencies only if @angular-devkit/build-angular isn't there already. That's because the @angular-devkit/build-angular already depends on @ngtools/webpack. This will prevent the plugin from adding multiple instances of @ngtools/webpack to the project which would cause the build to fail. related to #571, #569 BREAKING CHANGES Not really a breaking change but: It's a good idea to remove the `@angular-devkit/build-angular` from the package.json and add `@ngtools/webpack` instead as this will speed up the build. fixes #595
@vchimev
Copy link
Contributor

vchimev commented Jul 4, 2018

test

@sis0k0 sis0k0 merged commit 7b15418 into master Jul 4, 2018
@sis0k0 sis0k0 deleted the sis0k0/revert-build-angular-add branch July 4, 2018 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants