This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: consume shouldprepare hook #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rosen-vladimirov approved these changes Feb 28, 2018
Mitko-Kerezov force-pushed the kerezov/should-prepare branch from 347beb3 to a55f312 Compare 
Contributor
| test |
2 similar comments
Contributor
| test |
Contributor
| test |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Consume
shouldPreparehook in order to control when CLI should prepare the project.Project should be prepared every time webpack is invoked with different
envoptions.(e.g. first run was
tns run android --bundleand the second run istns run android --bundle --env.uglify)Merge after NativeScript/nativescript-cli#3399
Ping @rosen-vladimirov @sis0k0