This repository was archived by the owner on Aug 7, 2021. It is now read-only.
chore: Enable all unit test and test coverage #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vakrilov force-pushed the unit-tests branch from 40c5d7d to 7fa376d Compare 
KristianDD reviewed Sep 13, 2019
KristianDD approved these changes Sep 13, 2019
DimitarTachev approved these changes Sep 13, 2019
Fatme reviewed Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Only tests in the root of the repo were executed with
npm testWhat is the new behavior?
npm testsnpm run coveragethat will report code-coverage usingnyc(a.k.a. "the new istanbuljs")