This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: fix dependencies in package.json #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently `extra-watch-webpack-plugin` is not used anymore and should be deleted from package.json. `escape-string-regexp` is required from [bundle-config-loader](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/bundle-config-loader.ts#L4) but it is not dependency of `nativescript-dev-webpack` plugin. It's working at the moment because it is dependency of [fork-ts-checker-webpack-plugin](https://github.com/NativeScript/nativescript-dev-webpack/blob/2978b81b5a8100774b2bb4a331ac8637205927b8/package.json#L54).
rosen-vladimirov approved these changes Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently
extra-watch-webpack-pluginis not used anymore and should be deleted from package.json.escape-string-regexpis required from bundle-config-loader but it is not dependency ofnativescript-dev-webpackplugin. It's working at the moment because it is dependency of fork-ts-checker-webpack-plugin.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].