This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix(update-ns-webpack): skip the update of tsconfig.tns.json in shared Angular projects #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…d Angular projects The NativeScript Angular code-sharing projects, built with the [recommended structure](https://docs.nativescript.org/angular/code-sharing/intro), have a different `tsconfig.tns.json` file compared to the rest of the {N} project flavors. The update script, distributed by the `nativescript-dev-webpack` plugin shouldn't override that file when executed in a code-sharing project.
sis0k0 force-pushed the sis0k0/skip-shared-tsconfig-update branch from 19cc65d to c4105e5 Compare 
DimitarTachev approved these changes Jul 24, 2019
| test |
DimitarTachev pushed a commit that referenced this pull request Aug 1, 2019
The NativeScript Angular code-sharing projects, built with the [recommended structure](https://docs.nativescript.org/angular/code-sharing/intro), have a different `tsconfig.tns.json` file compared to the rest of the {N} project flavors. The update script, distributed by the `nativescript-dev-webpack` plugin shouldn't override that file when executed in a code-sharing project.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The NativeScript Angular code-sharing projects, built with the
recommended structure, have a different
tsconfig.tns.jsonfilecompared to the rest of the {N} project flavors. The update script,
distributed by the
nativescript-dev-webpackplugin shouldn't overridethat file when executed in a code-sharing project.