fix: android plugins now built using same “gradle” as apps #5671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* copy paste for now. I think most could be refactored in the runtime and cli should include from there * not kotlin, buildtools, … versions are define like in apps and use same defaults * we dont modify the build.gradle for tempPlugin anymore. Instead we add the plugin as a native dep (to itself..) and just ignore the `aar` that we would build (which can already be there). * now users can do almost anything they want in their plugin `include.gradle` and it will work (for example comments on the first line would break the build) * now while building a tempPlugin we pickup any external aar we find the plugin `platforms` folder (main reason for this change)
| @rigor789 thanks a lot for merging this! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
aarthat we would build (which can already be there).include.gradleand it will work (for example comments on the first line would break the build)platformsfolder (main reason for this change)