Add tests #35
Merged
Add tests #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test/test-bootstrap.ts Outdated
There was a problem hiding this comment.
This is unneeded. We don't have resource-loader
| LoggerStubs, FileSystemStubs and ErrorsStubs are duplicated with icenium-cli. It should be better to be extracted in |
Gruntfile.js Outdated
| The stub implementations are test-dependent. It is possible that a stub gets modified due to a specific need when testing a project-specific class. And, it is possible that various stubs exist depending on the test scenario. |
package.json Outdated
| squash and go 👍 |
Gruntfile.js Outdated
There was a problem hiding this comment.
We should make this platform agnostic so I can run it on my Mac as well. Consider using grunt-mocha for example.
| Almost there. 😄 Can you rebase it on master and squash it? |
| 👍 |
1 similar comment
| 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add mocha and should.js; Add a test; Adjust the grunt and the files accordingly.