Update marked dependency #3300
Merged
Update marked dependency #3300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TsvetanMilanov approved these changes Jan 5, 2018
Contributor
| Could you add some more information why we update the dependency please. |
Contributor Author
| @KristianDD modified the PR description to point out why this change is proposed |
KristianDD approved these changes Jan 5, 2018
rosen-vladimirov suggested changes Jan 8, 2018
Contributor
rosen-vladimirov left a comment
rosen-vladimirov left a comment There was a problem hiding this comment.
The shrinkwrap is incorrect - some optional dependencies have been removed. It looks like the shrinkwrap has been generated on Windows with npm version below 5.6.0
rosen-vladimirov force-pushed the kerezov/update-marked branch from e868efd to b6c4758 Compare 
Contributor
| I've updated the branch with correct shrinkwrap. I've also updated marked version to 0.3.12 |
rosen-vladimirov approved these changes Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update marked dependency to latest version and regenerate
npm-shrinkwrap.This is done as
marked0.3.6has some security vulnerabilities, which have been resolved in0.3.9as can be seen from the Github analysisPing @TsvetanMilanov @KristianDD @rosen-vladimirov