Removed NgElement #962
Merged
Removed NgElement #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost assigned 
| uitests |
| uitests |
vakrilov pushed a commit that referenced this pull request Aug 30, 2017
#945) * refactor(renderer): keep internal sibling queue for views * test: update test interface * refactor(renderer): fix setting of siblings * refactor(renderer): skip invisible nodes when using insertBefore * refactor(renderer): replace doubly linked list with singly linked one * refactor(renderer): split insert/remove of views to smaller methods methods for insert/remove from: - internal view queue (NgElements) - visual tree (NgViews) * refactor(renderer): set first child to every NgElement * style: fix linting errors * refactor(renderer): stop setting templateParents to `ProxyViewContainer`s * refactor: remove unused method from view-util * chore: remove yarn.lock * refactor(renderer): fix removal from internal queue and add trace for view util * test: fix unit tests for renderer * test(e2e): add app with nativescript-appium tests for renderer * test(e2e): fix examples for iOS Content views (Pages) cannot have multiple children and throw in iOS. * Template tag fixed * Removed NgElement (#962) * Removed NgElement * fix: TestProject does not compile * fix: subsequent *ngIf break renderer-a * chore(lint): remove unused import * refactor(view-util): extract the lookup for next visual view into method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.