Skip to content

fix(action-bar): ignore InvisibleNodes when adding title #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2017
Merged

fix(action-bar): ignore InvisibleNodes when adding title #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions nativescript-angular/directives/action-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { View } from "tns-core-modules/ui/core/view";

import { isBlank } from "../lang-facade";
import {
InvisibleNode,
NgView,
ViewClassMeta,
registerElement,
Expand All @@ -16,7 +17,9 @@ const actionBarMeta: ViewClassMeta = {
const bar = <ActionBar>(<any>parent);
const childView = <any>child;

if (child instanceof NavigationButton) {
if (child instanceof InvisibleNode) {
return;
} else if (child instanceof NavigationButton) {
bar.navigationButton = childView;
childView.parent = bar;
} else if (child instanceof ActionItem) {
Expand All @@ -30,7 +33,9 @@ const actionBarMeta: ViewClassMeta = {
const bar = <ActionBar>(<any>parent);
const childView = <any>child;

if (child instanceof NavigationButton) {
if (child instanceof InvisibleNode) {
return;
} else if (child instanceof NavigationButton) {
if (bar.navigationButton === childView) {
bar.navigationButton = null;
}
Expand Down