Upgrade nativescript-angular to ng2 RC6 #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Use *ONLY* the official bundles when importing code. No imports from `@angular/core/src/...` since those are incompatible ES6 modules now. - Copy a bunch of private NG2 APIs that are not exported by the bundles: - facade/lang + facade/collection - parse5_adapter - Renderer `CONTENT_ATTR` CSS constant - AnimationDriver interface definition - url_tree -> `containsTree` from `@angular/router` - `private_import_core`, `private_import_platform-browser`, `private_import_compiler` - DetachedLoader no longer loading stuff inside a child ViewContainerRef - DetachedLoader now properly using component factories. - Lazy require animation driver module in renderer to work around a circular import issue in tns-core-modules. - Router pushState now called before new component activation. Update location strategy hacks to accommodate that.
hdeshev force-pushed the hdeshev/ng-rc6 branch from 1311f48 to e38b3c8 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@angular/core/src/...since those are incompatible ES6 modules now.bundles:
CONTENT_ATTRCSS constantcontainsTreefrom@angular/routerprivate_import_core,private_import_platform-browser,private_import_compilerTODO
ViewTemplateRefremoval inDetachedLoader//cc @vakrilov