Skip to content

Added animations support in Angular 2 RC3 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2016
Merged

Added animations support in Angular 2 RC3 #303

merged 1 commit into from
Jul 6, 2016

Conversation

tzraikov
Copy link
Contributor

No description provided.

vakrilov
vakrilov reviewed Jun 28, 2016
View reviewed changes
nativescript-angular/animation-player.ts Outdated
if (this.animation && this.animation.isPlaying) {
this.animation.cancel();
}
// TODO: apply end values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: apply end values ?
@vakrilov
Copy link
Contributor

vakrilov commented Jun 28, 2016 •
edited
Loading

Couple of comments about the examples inside ng-sample:

  1. nativeScriptBootstrap(AnimationKeyframesTest) - doesn't show anything - both iOS and Android
  2. nativeScriptBootstrap(AnimationEnterLeaveTest) - taping on on of the items causes a crash - both iOS and Android
  3. nativeScriptBootstrap(AnimationEnterLeaveTest) - the enter animation doesn't seem to trigger on iOS
  4. nativeScriptBootstrap(AnimationStatesTest); - on Android - when triggering the animation the button background changes to white first and then form white to red/green
@tzraikov tzraikov force-pushed the raikov/animations-rc3 branch 5 times, most recently from 4809afc to 2bd2d16 Compare July 6, 2016 08:36
@tzraikov tzraikov force-pushed the raikov/animations-rc3 branch from 2bd2d16 to 4b70a7e Compare July 6, 2016 12:13
@vakrilov
Copy link
Contributor

vakrilov commented Jul 6, 2016

👍
brace
@tzraikov tzraikov merged commit 993b3d0 into master Jul 6, 2016
@tzraikov tzraikov deleted the raikov/animations-rc3 branch July 6, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tzraikov @vakrilov