Skip to content

FIX: ListView infinite change detection #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 14, 2016
Merged

FIX: ListView infinite change detection #288

merged 6 commits into from
Jun 14, 2016

Conversation

@vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Jun 13, 2016

Fixes:

  • Infinite ChangeDetection when ListView is used.
  • Trigger change detection on each item when it is loading.

Resolves #262
@vakrilov vakrilov changed the title List view samples List view fix for infinite change detection Jun 13, 2016
@vakrilov vakrilov changed the title List view fix for infinite change detection FIX: ListView infinite change detection Jun 13, 2016
@vakrilov vakrilov closed this Jun 14, 2016
@vakrilov vakrilov reopened this Jun 14, 2016
hdeshev
hdeshev reviewed Jun 14, 2016
View reviewed changes
nativescript-angular/directives/list-view-comp.ts Outdated
private _cdr: ChangeDetectorRef) {
private _iterableDiffers: IterableDiffers,
private _cdr: ChangeDetectorRef,
private _zone: NgZone) {
Copy link
Contributor

@hdeshev hdeshev Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_zone seems to be unused here.
@vakrilov vakrilov merged commit 93864b5 into master Jun 14, 2016
@vakrilov vakrilov deleted the list-view-samples branch June 14, 2016 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@vakrilov @hdeshev