Skip to content

fix(renderer): dynamic views can't be prepended #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(renderer): dynamic views can't be prepended #2262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(renderer): dynamic views can't be prepended
  • Loading branch information
@edusperoni
edusperoni committed Sep 21, 2020
commit 02fa2bb88b0ef19dcaccb14de3dc270303dbe1c8
6 changes: 5 additions & 1 deletion nativescript-angular/view-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ export class ViewUtil {
const extendedParent = this.ensureNgViewExtensions(parent);
const extendedChild = this.ensureNgViewExtensions(child);

if (!previous) {
// the element should be between previous and next
// if there's next but no previous, it's the first element
// if there's previous but no next, it's the last element
// elements that have no previous/next elements must be appended
if (!previous && !next) {
previous = extendedParent.lastChild;
}
this.addToQueue(extendedParent, extendedChild, previous, next);
Expand Down