Skip to content

fix: page navigation bug if there's not outlet for frame after cleari… #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2020
Merged

fix: page navigation bug if there's not outlet for frame after cleari… #2233

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eee94b
fix: page navigation bug if there's not outlet for frame after cleari…
bellalMohamed Aug 25, 2020
113ce43
making prettier happy
bellalMohamed Aug 26, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: page navigation bug if there's not outlet for frame after cleari… 
…ng history
  • Loading branch information
@bellalMohamed
bellalMohamed committed Aug 25, 2020
commit 0eee94bbedf849f3a113d5d8d4f2e9ca80ce4d5d
2 changes: 1 addition & 1 deletion nativescript-angular/router/ns-location-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ export class NSLocationStrategy extends LocationStrategy {
NativeScriptDebug.routerLog('NSLocationStrategy._beginPageNavigation()');
}

this.currentOutlet = this.getOutletByFrame(frame);
this.currentOutlet = this.getOutletByFrame(frame) || this.currentOutlet;
const lastState = this.currentOutlet.peekState();

if (lastState) {
Expand Down