Skip to content

fix(list-view): fix crash when used with ngFor #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 4, 2020
Merged

fix(list-view): fix crash when used with ngFor #2121

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
496c46d
fix(list-view): wrap ChangeDetection in ng zone
edusperoni Feb 12, 2020
a1caad5
fix(zone): patch AnimationFrame
edusperoni Feb 12, 2020
29c3e8c
fix(dialogs): wrap angular calls in ng zone
edusperoni Feb 12, 2020
308dd97
fix missing zone injection
edusperoni Feb 12, 2020
040d93d
Merge branch 'master' into zone-fixes
NathanWalker Jun 3, 2020
7d49a4d
chore: bump
NathanWalker Sep 3, 2020
9feea4b
chore: ng 10.1 and ns 7
NathanWalker Sep 3, 2020
7595d30
Merge branch 'feat/angular-10-1' of https://github.com/NativeScript/n…
edusperoni Sep 3, 2020
e7d3faf
chore: fix linting
edusperoni Sep 3, 2020
79ce7ce
Merge branch 'master' into zone-fixes
NathanWalker Sep 4, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into zone-fixes
  • Loading branch information
@NathanWalker
NathanWalker authored Jun 3, 2020
commit 040d93db708a9d2edfcc2a74c05bbcebaf7ad17f
2 changes: 1 addition & 1 deletion nativescript-angular/directives/dialogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class ModalDialogService {
});
const detachedFactory = options.resolver.resolveComponentFactory(DetachedLoader);
this.zone.run(() => {
detachedLoaderRef = options.containerRef.createComponent(detachedFactory, -1, childInjector, null);
detachedLoaderRef = options.containerRef.createComponent(detachedFactory, 0, childInjector, null);
detachedLoaderRef.instance.loadComponent(options.type).then((compRef) => {
const detachedProxy = <ProxyViewContainer>compRef.location.nativeElement;

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.