Skip to content

fix(hmr): After HMR app is blank when re-launched #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix(hmr): After HMR app is blank when re-launched #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions nativescript-angular/platform-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,8 @@ export class NativeScriptPlatformRef extends PlatformRef {
@profile
private bootstrapNativeScriptApp() {
const autoCreateFrame = !!this.appOptions.createFrameOnBootstrap;
let tempAppHostView: AppHostView;
let rootContent: View;

if (autoCreateFrame) {
const { page, frame } = this.createFrameAndPage(false);
setRootPage(page);
rootContent = frame;
} else {
// Create a temp page for root of the renderer
tempAppHostView = new AppHostView();
setRootPage(<any>tempAppHostView);
}

if (isLogEnabled()) {
bootstrapLog("NativeScriptPlatform bootstrap started.");
}
Expand All @@ -214,6 +203,17 @@ export class NativeScriptPlatformRef extends PlatformRef {
bootstrapLog("Application launch event fired");
}

let tempAppHostView: AppHostView;
if (autoCreateFrame) {
const { page, frame } = this.createFrameAndPage(false);
setRootPage(page);
rootContent = frame;
} else {
// Create a temp page for root of the renderer
tempAppHostView = new AppHostView();
setRootPage(<any>tempAppHostView);
}

let bootstrapPromiseCompleted = false;
this._bootstrapper().then(
moduleRef => {
Expand Down