fix: local development workflow errors #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elena-p previously approved these changes Oct 22, 2019
VladimirAmiorkov previously approved these changes Oct 22, 2019
tbozhikov dismissed stale reviews from VladimirAmiorkov and elena-p via d7c6f90 
| test --ignore |
| test --ignore |
elena-p approved these changes Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
when adding dependencies in
package.jsonwithfile: ..., the packages innode_modulesare not flattened (@nativescript/angularis not placed innode_modules' root, but undernativescript-angular'snode_modules) andtns build ... --env.aotcommand fails because paths are not resolved. That is why we need:"./node_modules/nativescript-angular/node_modules/*"added as path in tsconfigs