refactor: remove http module #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tgpetrov force-pushed the tgpetrov/remove-http-module branch from e837a4b to c12d2e5 Compare 
elena-p approved these changes Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There is a
NativeScriptHttpModulethat uses Angular deprecated APIsWhat is the new behavior?
NativeScriptHttpModuleis removed@angular/httpis removed from the dependenciesRelated with #1842 .
BREAKING CHANGES:
NativeScriptHttpModuleis removed@angular/httpis removed from the dependenciesMigration steps:
NativeScriptHttpModule, replace withNativeScriptHttpClientModuleas done here@angular/httpis no longer a peerDependency ofnativescript-angular, you can remove if from your dependencies