Skip to content

Conversation

@zbranzov
Copy link
Contributor

PR Checklist

@ghost ghost removed the in progress label Apr 24, 2019
@zbranzov zbranzov merged commit 652776a into master Apr 24, 2019
@ghost ghost removed the new PR label Apr 24, 2019
@zbranzov zbranzov deleted the zbranzov/new-test branch April 24, 2019 10:06
@SvetoslavTsenov
Copy link
Contributor

@DimitarTodorov, @zbranzov, decreasing from --timeout 140000 to --timeout 60000 is not a good idea a and will make the tests very flaky.
Usually there could be few steps that could slow down tests and have nothing to do with the test.
For example when we are trying to start/ restart Appium server it will take a lot of time or for some reason the device should be started/restarted. This will reflect to the test execution time taking a few minutes. Running tests in parallel also slows down the execution time.
If some of the test is failing because some element is not visible, sometime it takes a lot of execution time as well and at the end because of one test failure you will not have the result of the rest of the rest of tests and e.t.c.
Also adding a new test will require to change execution time each time.

The good part here is that this will not take an effect of the CI execution but still you are not familiar with the test and trying to execute test and we need to start device and etc it will be very frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants