Skip to content

fix(NativeScriptPlatformRef): Destroy lastModuleRef on exitEvent #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 15, 2019
Merged

fix(NativeScriptPlatformRef): Destroy lastModuleRef on exitEvent #1728

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a21454f
chor(NativeScriptPlatformRef): Destroy lastModuleRef on exitEvent
m-abs Feb 12, 2019
a4ee021
fix(tslint): missing whitespace
m-abs Feb 12, 2019
1119e2a
Merge branch 'master' into fix/923-module-not-destroyed
Feb 19, 2019
bdd3250
Merge branch 'master' into fix/923-module-not-destroyed
m-abs Feb 20, 2019
f9b1d0c
Merge branch 'fix/923-module-not-destroyed' of github.com:m-abs/nativ…
m-abs Feb 20, 2019
14e787f
fix: remove rootContent on exit
m-abs Feb 21, 2019
ea66985
fix: page might be null'ed before clearHistory's navigatedToEvent
m-abs Feb 22, 2019
16af2e8
Merge branch 'master' into fix/923-module-not-destroyed
m-abs Mar 5, 2019
5e13263
fix: on destroy remove the lastBootstrappedModule
m-abs Mar 8, 2019
30db0d2
Merge branch 'fix/923-module-not-destroyed' of github.com:m-abs/nativ…
m-abs Mar 8, 2019
3dffbd5
fix: the exit event is triggered on restart
m-abs Mar 11, 2019
9122c23
Merge branch 'master' into fix/923-module-not-destroyed
m-abs Mar 12, 2019
72d877b
Merge branch 'master' into fix/923-module-not-destroyed
Apr 5, 2019
ac9a59f
Merge branch 'master' into fix/923-module-not-destroyed
elena-p Apr 12, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tslint): missing whitespace
  • Loading branch information
@m-abs
m-abs committed Feb 12, 2019
commit a4ee021fb0f3b74cf2ee3b0b9ec5ca06e8b1ec61
2 changes: 1 addition & 1 deletion nativescript-angular/platform-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class NativeScriptPlatformRef extends PlatformRef {
}
);
const exitCallback = profile(
"nativescript-angular/platform-common.exitCallback",() => {
"nativescript-angular/platform-common.exitCallback", () => {
const lastModuleRef = lastBootstrappedModule ? lastBootstrappedModule.get() : null;
if (lastModuleRef) {
lastModuleRef.destroy();
Expand Down