chore: update beta.13, zone 0.6.8 #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| build: { | ||
| src: [ | ||
| 'src/**/*.ts', | ||
| 'node_modules/tns-core-modules/tns-core-modules.d.ts', |
There was a problem hiding this comment.
This makes tsc compilation happy.
| }); | ||
| | ||
| page.on('navigatingFrom', (<any>global).zone.bind((args: NavigatedData) => { | ||
| page.on('navigatingFrom', (<any>global).Zone.bind((args: NavigatedData) => { |
There was a problem hiding this comment.
Once we get the new zone api correct, we will need to update this as well.
| 10x for the effort @NathanWalker - I have pushed another PR for update directly to beta 14 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #151
@hdeshev This is close it seems (80% there). Running into this at moment:
Wanted to go ahead and push where I'm at. Maybe the final fix is more obvious to you?
If you want to pull this branch and continue from this point would be great if this looks like the right direction.
It's all dependent upon this PR getting merged though:
angular/zone.js#305
^ Due to that, you will need to manually patch zone.js after your
npm installwith the fix in that PR and then you can could continue work here.