fix(modal): closeCallback(...) no side effects on multiple calls #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ed multiple times
ghost assigned 
manoldonev changed the title manoldonev requested review from ADjenkov, MartoYankov, sis0k0, tbozhikov, vakrilov and vchimev 
MartoYankov approved these changes May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
modalParams.closeCallback(...) should not have side effects if called multiple times.
Fixes #1350
TODO: add ui test for this scenario as soon as we migrate the modal navigation test app to Angular.