This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Fix for Sign Up Button on Chapter 3.4 Services #758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When the user press the Sign Up Button it doesn't do anything. This set's the isLoggingIn property to false so that signUp() can be called.
Fix for Sign Up Button on Chapter 3.4 Services
| Hey @kurapikats, Thanks for the contribution, but this change shouldn’t be necessary, as in section 3.4 the instructions say to click the bottom “Sign up” button, and then the top “Sign up” button which calls register. Now that I’m typing this out though I’m realizing how confusing this probably is. I think a better solution is probably renaming at least one of these buttons to avoid the ambiguity. |
| I’m going to close this one for now, but I added button renaming to the list of revisions that need to happen in the next version of this tutorial. Thanks again @kurapikats |
| This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When the user press the Sign Up Button it calls login() but it doesn't do anything.
To fix this: set the this.isLoggingIn property to false so that signUp() can be called.