Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Updating documentation related to mod30 changes #746

Merged
merged 8 commits into from
May 2, 2017
Merged

Updating documentation related to mod30 changes #746

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
75c1632
documentation changes related to versions 3.0.0
NickIliev Apr 7, 2017
85db518
edit styling article
Apr 7, 2017
3b6fcc3
added changes in styling.md ui=plugin.md and in location.md
NickIliev Apr 10, 2017
9c2fb5e
ts imoports with ES6 syntax
NickIliev Apr 10, 2017
b8125c5
utils module article
Apr 26, 2017
e8569fe
article and snipets revisions
NickIliev May 2, 2017
bafcb3d
final snippet TS revisions
NickIliev May 2, 2017
7bce343
improved application imports
NickIliev May 2, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions core-concepts/accessing-native-apis-with-javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,16 @@ Steps to install and enable
- Modify `tsconfig.json` to contain the following settings:
```
{
"compilerOptions": {
"module": "commonjs",
"target": "es5",
"experimentalDecorators": true,
"lib": [
"es2016"
"compilerOptions": {
...
"lib": ["es6", "dom"]
Copy link
Contributor

@sis0k0 sis0k0 May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have comma at the end of the row
"baseUrl": ".",
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
]
}
}
}
```
Note that d.ts files require a lot of memory and CPU. Consider adding skipLibCheck option to `tsconfig.json`.
Expand Down
14 changes: 7 additions & 7 deletions core-concepts/application-lifecycle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Components are the fundamental building blocks of NativeScript applications buil
### Component example

``` TypeScript
import {Component} from "@angular/core";
import { Component } from "@angular/core";

@Component({
selector: "main-component",
Expand Down Expand Up @@ -148,7 +148,7 @@ application.start({ moduleName: "main-page" });
iOS calls UIApplication and triggers the application main event loop.
*/

import application = require("application");
import * as application from "application";
Copy link
Contributor

@sis0k0 sis0k0 May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import only the used methods from application?

import { on, uncaughtErrorEvent } from "application";
Copy link
Contributor Author

@NickIliev NickIliev May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed but I think it is better to leave this specific example to import application as it is more readable application.on instead of just on
Copy link
Contributor

@sis0k0 sis0k0 May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use:
import { on as applicationOn }

the application module exports 46 things and we don't need most of them. If we import the whole module we can't benefit from the treeshaking that uglify.js performs.
application.start({ moduleName: "main-page" });
```
{% endnativescript %}
Expand Down Expand Up @@ -234,7 +234,7 @@ application.start({ moduleName: "main-page" });
```
{% endnativescript %}
``` TypeScript
import application = require("application");
import * as application from "application";
application.on(application.launchEvent, function (args: application.ApplicationEventData) {
if (args.android) {
// For Android applications, args.android is an android.content.Intent class.
Expand Down Expand Up @@ -360,7 +360,7 @@ application.start();
```
{% endnativescript %}
``` TypeScript
import application = require("application");
import * as application from "application";

// Android activity events
if (application.android) {
Expand Down Expand Up @@ -435,7 +435,7 @@ application.start();
```
{% endnativescript %}
``` TypeScript
import application = require("application");
import * as application from "application";
class MyDelegate extends UIResponder implements UIApplicationDelegate {
public static ObjCProtocols = [UIApplicationDelegate];

Expand Down Expand Up @@ -481,8 +481,8 @@ exports.pageLoaded = pageLoaded;
```
{% endnativescript %}
``` TypeScript
import observable = require("data/observable");
import applicationSettings = require("application-settings");
import * as observable from "data/observable";
Copy link
Contributor

@sis0k0 sis0k0 May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { EventData } from "data/observable";
import * as applicationSettings from "application-settings";
Copy link
Contributor

@sis0k0 sis0k0 May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here
// Event handler for Page "loaded" event attached in main-page.xml.
export function pageLoaded(args: observable.EventData) {
applicationSettings.setString("Name", "John Doe");
Expand Down
Loading