Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

@roblav96
Copy link
Contributor

@roblav96 roblav96 commented Sep 10, 2016

If there's a better way to do this, let me know.

Some platform qualifier modules were bundled correctly without this, but most were not when using ng2-rc6.

im importing import {Permissions} from "../../shared/permissions/permissions" which is an injectable service, but i have permissions.ios and permissions.android. it looks like its bundling the permissions file, which is dummy typescript declarations, and ignoring the platform file patterns

[667] ./shared/permissions/permissions.js 287 bytes {0} [built] but it SHOULD be bundling ./shared/permissions/permissions.ios.js

@walkerrunpdx yes but i have import "./shared/delegates/delegate" in my main.js which is really /delegate.ios and in the bundler it reports [682] ./shared/delegates/delegate.ios.js 1.38 kB {0} [built] so thats working

plus the file size of permissions.ios.js is certainly not 287 bytes. thats the size of the dummy declarations file

If there's a better way to do this, let me know. Some platform qualifier modules were bundled correctly without this, but most were not when using `ng2-rc6`.
@hdeshev
Copy link
Contributor

hdeshev commented Sep 26, 2016

Thanks for your contribution! I realize that documenting this feels like a suboptimal approach (as opposed to solving the issue in nativescript-dev-webpack), but for now it's better than nothing.

I am working on a change to module resolution for nativescript-dev-webpack that already takes care of .android.js and .ios.js extensions, but it may require some changes to user projects and is not ready to be released yet.

@hdeshev hdeshev merged commit 05bc230 into NativeScript:master Sep 26, 2016
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants