Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

teobugslayer
Copy link
Contributor

No description provided.


> ruby -e "$(curl -fsSL https://github.com/NativeScript/nativescript-cli/blob/production/setup/native-script.rb)"
The script calls some of the commands using `sudo` and you will need to provide your password several times.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's strange, sudo is caching the "login" for some time, so you should be prompted only once

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I agree to keep it this way, just to be sure users are warned :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some commands execute so slowly that the sudo authentication cache expires. See the docs. At any rate, it does prompt multiple times. But I will change the wording to "may".

@rosen-vladimirov
Copy link
Contributor

👍

@teobugslayer teobugslayer force-pushed the setip-win branch 2 times, most recently from 38da498 to 38c2a90 Compare February 15, 2016 12:13

### Quick setup

If this is your first time developing mobile project, consider using our one-liner scripts to quickly setup your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading, one asks "what are these one-liner scripts?" and gets confused. We might better say "...consider using the one-liner scripts in this section to...".

Let's refrain from using "our". This is an open-source project and is owned by the entire world shall they want to contribute for good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used "our" in the sense of "provided by the project maintainers". At any rate, I will change the wording to more neutral one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developing mobile project --> developing a mobile project

@tjvantoll
Copy link
Contributor

Just to make one suggestion: IMO it makes more sense for these scripts to be listed on the OS-specific pages—i.e. http://docs.nativescript.org/start/ns-setup-win and http://docs.nativescript.org/start/ns-setup-os-x—as there are a few places we link to the Windows/OS X specific pages already (for instance the Getting Started Guide). If we are going to keep the scripts listed on the quick setup, I would rename the OS-specific pages as the “advanced” guides.

@tjvantoll
Copy link
Contributor

I’d also recommend telling people that these scripts may potentially take a really long time to complete to set the appropriate expectations.

@ErjanGavalji
Copy link
Contributor

👍 for @tjvantoll's links-from-os-specific-docs suggestion

@teobugslayer teobugslayer force-pushed the setip-win branch 2 times, most recently from 9bf8df2 to 1e6d4d0 Compare February 19, 2016 16:48
@teobugslayer
Copy link
Contributor Author

ping @tjvantoll @ikoevska @ErjanGavalji for final approval.

* Android SDK Build-tools 22.0.0 or a later stable official release
* (Optional) Genymotion to expand your testing options

### Quick setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit picky, but this should probably be an h2 and not an h3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after looking this over more, “Quick setup” should be an h2 on the OS X and Windows pages, but an h3 on the installation page.

@tjvantoll
Copy link
Contributor

I just added a few small things. Overall this looks great.

The only concern I have is that the scripts themselves are now duplicated in multiple locations. The docs support Markdown snippets via !!include (example), so you may want to consider using that here so these scripts don’t get out of sync.

@teobugslayer
Copy link
Contributor Author

@tjvantoll, i have fixed the typos. I'd rather leave to you to change the markdown to use includes because I do not feel confident enough using them. I agree that they are the better approach.

Change sys requirements to Win7 spq Include Node.js 5.x in setup instructions Fix OS X Node.js installation instructions
teobugslayer added a commit that referenced this pull request Feb 24, 2016
@teobugslayer teobugslayer merged commit 905c5f5 into master Feb 24, 2016
@teobugslayer teobugslayer deleted the setip-win branch February 24, 2016 14:48
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants