Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

jasssonpet
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontmatter is missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I am not really seeing the connection between the title (the H1) and the contents of the article. Probably go with something along the lines of "Using JavaScript Modules in NativeScript Apps" or "Referencing JavaScript Modules in NativeScript Apps".

@jasssonpet jasssonpet force-pushed the jasssonpet/docs branch 8 times, most recently from 817bce4 to ff9b642 Compare December 10, 2015 15:28
@jasssonpet
Copy link
Contributor Author

Thank you @ikoevska for your comments. I've made some changes to the article 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatting for require here. (It gets lost in the text without it.)

@ikoevska
Copy link
Contributor

Just a few cosmetic comments. 👍 for the docs part of it after applying the comments. It might be a good idea to wait for review from another team member with more tech expertise than me. =)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider documenting module.require as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fealebenpae Ah, I've missed that one 👍

@fealebenpae
Copy link

Looks good to me.

jasssonpet added a commit that referenced this pull request Dec 16, 2015
@jasssonpet jasssonpet merged commit 0d4ed6c into master Dec 16, 2015
@jasssonpet jasssonpet deleted the jasssonpet/docs branch December 16, 2015 13:33
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants