Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

@hettiger
Copy link
Contributor

@hettiger hettiger commented Apr 2, 2019

PR Checklist

What is the current state of the documentation article?

There's no warning about HMR incompatibility with RadSideDrawer as root view.

See: NativeScript/NativeScript#6398

What is the new state of the documentation article?

Now there is a warning.

@cla-bot cla-bot bot added the cla: yes label Apr 2, 2019
@NickIliev
Copy link
Contributor

NickIliev commented Apr 4, 2019

@hettiger I think the warning in the documentation is not needed as we are currently working on HMR improvements including when the root is RadSideDrawer or TabView.

In fact, the HMR should work with RadSideDrawer even as we speak but with no state management and with some cases where a restart ()instead of reloading) needed. Can you please let us know what the specific issue with RadSideDrawer and HMR is and if there is a bug you can log it in nativescript-cli repository

@NickIliev NickIliev closed this Apr 4, 2019
@NickIliev NickIliev reopened this Apr 4, 2019
@hettiger
Copy link
Contributor Author

hettiger commented Apr 4, 2019

@NickIliev

In fact, the HMR should work with RadSideDrawer even as we speak but with no state management and with some cases where a restart ()instead of reloading) needed.

HMR was not working at all but logs looked very promising and I didn't understand why I would not see any changes applied. All documents related to HMR were making me beliefe I could use it. (Out of beta, etc.) I was debugging for quite some time until I found the mentioned ticket that made me ask in Slack.

Maybe it will be working in the next release but the warning might save some people a lot of time and headaches.

Please reconsider adding it temporarily.

@vchimev
Copy link
Contributor

vchimev commented Apr 25, 2019

Hey @hettiger,

I opened https://github.com/NativeScript/docs/pull/1639 reflecting the state of HMR with 5.4.

I would appreciate your opinion on it.

Thanks!

@hettiger
Copy link
Contributor Author

@vchimev sorry for the late reply. LGTM but I'm not sure how this connects to my proposal.

@vchimev
Copy link
Contributor

vchimev commented Jul 22, 2019

In the latest version 6.0 of NativeScript, changes in an application with a side drawer as root apply at runtime. For Angular - the application bootstraps on a change.

Please, log any issues you experience as bug reports.

@vchimev vchimev closed this Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 participants