Fix scroll sidebar docs #1492
Fix scroll sidebar docs #1492
Conversation
Added NsSideScroll function in app.js and appended ns-side-nav-active to the left sidebar. In the Styles.css included syling for the ns-side-nav-active class and ns-side-nav Fix scroll on side navigations
Creation of navigation__right__scroll to right nav container element. handleScrollNav function created to allow for more visibility while scrolling down on page. styles applied to navigation__right__scroll class in Styles.css add #ns-side-scroll for left side scroll Fix of issue for right side navigation scroll
update pull request with profile to contribution
| Many thanks for your effort. While reviewing the suggestion I noticed a redundant scrollbar, that ideally shouldn't be there - |
changed overflow to overflow-y on side-side-nav
Added display none for webkit and firefox to hide scroll bar of right side navigation
| I found a solution for the navbar that possibly only works for webkit and firefox.. I'm not sure how it looks on IE... maybe y'all have a suggestion on how to implement a fix for it there too :) Thank you guys for this opportunity! |
| So yes you were right.. no JS needed haha.. I made this waaay too complicated than it needed to be. Thank you for the great advice!
Once I do a full check again I'll push the changes |
| Thanks. Btw, looking at your screenshots - the colors of the scrollbar are inverted than what I had in mind - the scroll-thumb should be --border-light-blue and the scroll-track should be transparent. |
|
|
Added border-lightbue color to scrollbar thumb and applied styles to right-nav__tree for scroll Deleted navigation__right__scroll and ns-side-scroll selectors fixes issue NativeScript#1455
| I just pushed the next round of revisions :) gracias |
| Thanks for your effort! 👍 |
| Thank you guys! I learned lots :) |
| Hey, thanks for your contribution! We have a special program for our first-time contributors and you are eligible to participate in it. If you haven't applied already, all you need to do to claim your prize is to fill our Application Form. Regards from the whole team 🥇 |
| This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
PR Checklist
What is the current state of the documentation article?
#1455 , implemented scroll effect for both left and right sidebars. Both sidebars didn't have the ability to scroll on content, causing difficulty in UX and navigation on tabs.
What is the new state of the documentation article?
The side navbars should have the ability to scroll to allow for easier access to tabs. Also they are now sticky on the page to always show and have access to their navigations.
Fixes/Implements/Closes #[Issue Number].
Fixes #1455