Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

tjvantoll
Copy link
Contributor

Ping @ikoevska

I'm trying to make the guide match up exactly with the master branch, so it's an accurate reference for users going through the tutorial.

The big change that was in master was using fetch instead of the http module, so I implemented that in the guide, and there were a few naming discrepancies.

There are a few other trivial things I noticed while going through the guide in its entirety again. Let me know what you think.

@tjvantoll
Copy link
Contributor Author

The other thing I need to add is a small section on ActivityIndicator. I didn't quite finish that section so it's not in this PR yet. I'll get to it tomorrow morning.

@tjvantoll
Copy link
Contributor Author

Alright the section on ActivityIndicators is in there now. This is ready for a review.

@tjvantoll
Copy link
Contributor Author

Ping @ikoevska. I think all the 1.3 changes are in here now. I'll do one more run through to verify that, but this content is ready to be looked at.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe tns run android --emulator --geny <Name> works. However, people need to check their Geny devices and so on. So your option is a good start.

@tjvantoll
Copy link
Contributor Author

Thanks @ikoevska. I believe I addressed all the comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a general rule in the docs world to avoid lists containing one item. You can leave this as it is (that's why I didn't comment the first time) but I suggest trying locally how making this a top-level list item and renaming it to node_modules/tns-core-modules works out. If you like how it looks, you can apply the change here as well.

@ikoevska
Copy link
Contributor

Looking good, check my comment about the tns modules folder description and see if you might want to apply it. Whichever you choose, you have a 👍 for merging this.

@tjvantoll
Copy link
Contributor Author

I took your suggestion of keeping the list of folder/files all top level. Thanks again for the review. I'll merge this in.

@tjvantoll tjvantoll closed this in 337118b Sep 11, 2015
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants