-
- Notifications
You must be signed in to change notification settings - Fork 447
Split quick start #134
Split quick start #134
Conversation
…quick-start Conflicts: getting-started.md
getting-started/chapter-0.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st sentence -> getting started guide
2nd sentence -> guided tutorial
You can just drop the guided part (as it is pretty obvious :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this change be lost? It doesn't appear here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my bad screwing up a merge. The change is there now.
getting-started/chapter-5.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the case of this module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edited
Ok I believe all comments have been addressed now. I also pushed a few small edits per a review from Niki. |
Frankly, I don't think I can provide any more meaningful comments if I do another review this or next week. By the third/fourth read, I usually become "blind" to some parts of the text and tend to miss obvious typos/errors. I think we should deploy and test this on testdocs.nativescript.org and give it a few iterations of testing. |
One more thing that we might want to address - imho all links to docs.nativescript.org should be relative instead. |
All links are now relative. |
I'm in favor of deploying this as soon as is reasonably possible. It'd be nice to point people testing this guide to testdocs rather than the now out of date https://github.com/NativeScript/quick-start. |
You have my 👍 for merging and deploying this as soon as possible. While fixing any technical issues that might come up from testing, we can also fix any other style/phrasing issues as well. |
Done :) I'll work on getting my Jekyll changes merged in so we can view this live. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ping @ikoevska @jlooper
I split things up for sanity, and put this in a new PR so we can actually open this. Are there any outstanding issues from NativeScript/docs#128 that we need to address?