Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

tjvantoll
Copy link
Contributor

Ping @ikoevska @jlooper

I split things up for sanity, and put this in a new PR so we can actually open this. Are there any outstanding issues from NativeScript/docs#128 that we need to address?

@tjvantoll
Copy link
Contributor Author

I just verified that the include syntax is working as intended with some big help from @hdeshev. Once @ikoevska signs off on the content we should be good to go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st sentence -> getting started guide
2nd sentence -> guided tutorial

You can just drop the guided part (as it is pretty obvious :))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this change be lost? It doesn't appear here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my bad screwing up a merge. The change is there now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the case of this module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited

@tjvantoll
Copy link
Contributor Author

Ok I believe all comments have been addressed now. I also pushed a few small edits per a review from Niki.

@ikoevska
Copy link
Contributor

ikoevska commented Sep 3, 2015

Frankly, I don't think I can provide any more meaningful comments if I do another review this or next week. By the third/fourth read, I usually become "blind" to some parts of the text and tend to miss obvious typos/errors. I think we should deploy and test this on testdocs.nativescript.org and give it a few iterations of testing.

@ikoevska
Copy link
Contributor

ikoevska commented Sep 3, 2015

One more thing that we might want to address - imho all links to docs.nativescript.org should be relative instead.

@tjvantoll
Copy link
Contributor Author

One more thing that we might want to address - imho all links to docs.nativescript.org should be relative instead.

All links are now relative.

@tjvantoll
Copy link
Contributor Author

Frankly, I don't think I can provide any more meaningful comments if I do another review this or next week. By the third/fourth read, I usually become "blind" to some parts of the text and tend to miss obvious typos/errors. I think we should deploy and test this on testdocs.nativescript.org and give it a few iterations of testing.

I'm in favor of deploying this as soon as is reasonably possible. It'd be nice to point people testing this guide to testdocs rather than the now out of date https://github.com/NativeScript/quick-start.

@ikoevska
Copy link
Contributor

ikoevska commented Sep 3, 2015

You have my 👍 for merging and deploying this as soon as possible. While fixing any technical issues that might come up from testing, we can also fix any other style/phrasing issues as well.

tjvantoll added a commit to tjvantoll/docs that referenced this pull request Sep 3, 2015
@tjvantoll tjvantoll merged commit 8cb330f into NativeScript:master Sep 3, 2015
@tjvantoll
Copy link
Contributor Author

You have my 👍 for merging and deploying this as soon as possible. While fixing any technical issues that might come up from testing, we can also fix any other style/phrasing issues as well.

Done :)

I'll work on getting my Jekyll changes merged in so we can view this live.

@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants