This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Update(app icons and launch screens): Add iPhone X resolutions and fi… #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tjvantoll approved these changes Dec 19, 2017
| * **app/App_Resources/iOS/Assets.xcassets**: The resource that holds your image asset catalogs (for AppIcons, LaunchImages and LaunchScreen). | ||
| | ||
| * **app/App_Resources/iOS/LaunchScreen.storyboard**: Your default storyboard used for your launch screen (used in iOS versions 8, 9 and 10). | ||
| * **app/App_Resources/iOS/LaunchScreen.storyboard**: Your default storyboard used for your launch screen (used in iOS versions 8, 9, 10 and 11). |
There was a problem hiding this comment.
I think I’ll change this to iOS versions 8+ just so we don’t have to come back to this again 😄
| |------------------|------------------|-------------------------------------| | ||
| |iPhone 1g-3Gs | 320x480 | Default.png | | ||
| |iPhone 4, 4s | 640x960 | Default@2x.png | | ||
| |iPhone 5, 5c, 5s | 640x1136 | Default-568h@2x.png | |
There was a problem hiding this comment.
This isn’t related to your PR, but I noticed that Jekyll randomly turns some of these image names into links. See https://docs.nativescript.org/publishing/creating-launch-screens-ios#customizing-launch-images.
I think I’ll put all of these things in <code> tags to (hopefully) avoid that.
| Merged with 9e02b27. Thanks @tdermendjiev! |
| This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add iPhone X resolutions and fix typos