Skip to content

Conversation

@chang-l
Copy link
Collaborator

@chang-l chang-l commented Jul 7, 2025

Llama4 multimodal support

Description

Small fix for the following error from

"You cannot specify both input_ids and inputs_embeds at the same time, and must specify either one"

Test Coverage

python3 quickstart_multimodal.py --model_dir meta-llama/Llama-4-Scout-17B-16E-Instruct --modality image --tp_size 8 --max_num_tokens 4096

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chang-l chang-l requested review from milesial and symphonylyh July 7, 2025 22:20
@chang-l chang-l marked this pull request as ready for review July 7, 2025 22:21
@chang-l chang-l requested a review from a team as a code owner July 7, 2025 22:21
@chang-l chang-l requested a review from juney-nvidia July 7, 2025 22:21
Copy link
Collaborator

@rakib-hasan rakib-hasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chang-l
Copy link
Collaborator Author

chang-l commented Jul 7, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11185 [ run ] triggered by Bot

@chang-l chang-l enabled auto-merge (squash) July 7, 2025 22:44
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11185 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8274 completed with status: 'FAILURE'

@chang-l
Copy link
Collaborator Author

chang-l commented Jul 8, 2025

/bot run --disable-fail-fast

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l
Copy link
Collaborator Author

chang-l commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11208 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11208 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #8292 completed with status: 'FAILURE'

@chang-l
Copy link
Collaborator Author

chang-l commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11333 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11333 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8384 completed with status: 'FAILURE'

@chang-l
Copy link
Collaborator Author

chang-l commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11347 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11347 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8398 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@chang-l chang-l merged commit 4df5f96 into NVIDIA:main Jul 9, 2025
3 checks passed
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants