Skip to content

correcting filter_triplets function #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunjose696 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

correcting filter_triplets function #940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b8f4c
Update preprocessing.py
arunjose696 May 21, 2021
376ff24
Merge pull request #1 from arunjose696/arunjose696-patch-1
arunjose696 May 21, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TensorFlow/Recommendation/VAE-CF/vae/load/preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ def filter_triplets(tp, min_uc=5, min_sc=0):
# Only keep the triplets for items which were clicked on by at least min_sc users.
if min_sc > 0:
itemcount = get_count(tp, 'movieId')
tp = tp[tp['movieId'].isin(itemcount.index[itemcount >= min_sc])]
tp = tp[tp['movieId'].isin(itemcount.index[itemcount["size"] >= min_sc])]

# Only keep the triplets for users who clicked on at least min_uc items
# After doing this, some of the items will have less than min_uc users, but should only be a small proportion
if min_uc > 0:
usercount = get_count(tp, 'userId')
tp = tp[tp['userId'].isin(usercount.index[usercount >= min_uc])]
tp = tp[tp['userId'].isin(usercount.index[usercount["size"] >= min_uc])]

# Update both usercount and itemcount after filtering
usercount, itemcount = get_count(tp, 'userId'), get_count(tp, 'movieId')
Expand Down