Updated README, Fixed class parameter #1025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…never updated in models.py
Added missing line: wget -qO- https://raw.githubusercontent.com/soumith/imagenetloader.torch/master/valprep.sh | bash in the Data Processing section of the Quick Start guide. This line makes individual folders for all the classes, and was missing here but present in the MxNet README.
Tabbed over the line: wget -qO- https://raw.githubusercontent.com/soumith/imagenetloader.torch/master/valprep.sh | bash under data preparation in the Quick Start guide. It was appearing outside of the markdown text box.
Added line: wget -qO- https://raw.githubusercontent.com/soumith/imagenetloader.torch/master/valprep.sh | bash in markdown block for dataset preparation under Quick Start guide. This line was present in the MxNet readme, but missing in TensorFlow.
Added line: wget -qO- https://raw.githubusercontent.com/soumith/imagenetloader.torch/master/valprep.sh | bash in markdown block for dataset preparation under Quick Start guide. This line was present in the MxNet readme, but missing in TensorFlow, and necessary for processing with the script given in the next line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updated the README files for MxNet and TensorFlow for Image Classification.
The Quick Start guides were missing a line crucial to data preperation:
wget -qO- https://raw.githubusercontent.com/soumith/imagenetloader.torch/master/valprep.sh | bash
This line seperates the ImageNet data into classes, and is needed for preprocessing with the given script for TensorFlow.
In addition, for MxNet, the num-classes parameter was passed through from the command line, but never updated in models.py.