Skip to content

[TASK] Add native type declarations for anonymous functions #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

[TASK] Add native type declarations for anonymous functions #841

merged 2 commits into from
Jan 28, 2025

Conversation

oliverklee
Copy link
Collaborator

Also make then static if possible.
@oliverklee oliverklee requested a review from JakeQZ January 28, 2025 09:12
@oliverklee oliverklee self-assigned this Jan 28, 2025
@coveralls
Copy link

coveralls commented Jan 28, 2025 •
edited
Loading

Coverage Status

coverage: 44.039%. remained the same
when pulling 30a1120 on cleanup/static-functions
into 436a954 on main.
JakeQZ
JakeQZ requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but think a couple more closures can be made static, while we're here.
@oliverklee oliverklee force-pushed the cleanup/static-functions branch from 694d510 to 30a1120 Compare January 28, 2025 22:31
@oliverklee oliverklee requested a review from JakeQZ January 28, 2025 22:32
@JakeQZ JakeQZ merged commit bd206a2 into main Jan 28, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/static-functions branch January 28, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup

3 participants

@oliverklee @coveralls @JakeQZ