[FEATURE] Add PHP 8.4 to the CI matrix #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Note: This is the backport of #657. |
JakeQZ approved these changes Aug 26, 2024
There was a problem hiding this comment.
I'm sure we've covered this before. I'm just wondering why we can't run the unit tests against PHP 8.x on this branch.
For PHP 5.6 we may need an older version of PHPUnit, and for PHP 8 a newer one, but shouldn't Composer be able to sort that out, as long as our usage of PHPUnit is compatible with the various versions of it?
I'm currently trying this in #682. Let's see how this works out … |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.