Replace invalid turns unit with turn #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
westonruter force-pushed the fix/turns-unit branch from b1f7479 to e104c81 Compare 
| Can we cover this with a regression test? |
| @oliverklee I'm not sure what you mean. I added a test to ensure that |
| @westonruter I'm sorry, I totally missed that the PR indeed includes a regression test. Thanks! |
| Thanks! |
westonruter added a commit to westonruter/PHP-CSS-Parser that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes merge conflicts for the key change in #193 which replaces the invalid
turnsinit withturn, as identified by @pierlon:The use of
turnsin this codebase goes back 10 years.