fix: CUDA OOM encountered with store based barrier #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CUDA out-of-memory (OOM) issue related to unnecessary process group creation when using store-based barriers for full broadcast operations.
Key Changes:
- Avoids creating a redundant process group when
ranksisNoneor empty by conditionally callingdist.new_group()only when a subset of ranks is specified - Updates type hints to reflect that
ranks_groupcan beNonein_detect_bucket_sizeand_update_per_bucketmethods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
specture724 force-pushed the fix/cuda_oom branch from acba4df to 87b3b82 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.