fix(config): remove inject option #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for this! |
| No problem! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Im honestly not sure exactly what the
injectoption does for webpack dev server (pretty sure its deprecated in the latest version of webpack dev server) as I could not find any info on it but: A: removing it gets rid of this errorInvalid configuration object. webpack-dev-server has been initialised using a configuration object that does not match the API schema.when trying to build the app, B: it does not seem to break anything with the build when removing it. If i'm being ignorant and this does actually break something, feel free to close this PR (: