Skip to content

Add "events" to block response #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grkamil merged 2 commits into from
Sep 18, 2018
Merged

Add "events" to block response #27

grkamil merged 2 commits into from
Sep 18, 2018

Conversation

@i7495
Copy link
Contributor

@i7495 i7495 commented Sep 17, 2018

Fixes #26
grkamil
grkamil requested changes Sep 17, 2018
View reviewed changes
src/Minter/MinterAPI.php Outdated
$uri .= '?withEvents=true';
}

return $this->get($uri);
Copy link
Member

@grkamil grkamil Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the return response in one line. Like this
return $this->get('/api/block/' . $height . ($withEvents ? '?withEvents=true' : ''))
Copy link
Contributor Author

@i7495 i7495 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the review.
@grkamil grkamil merged commit 8bffa48 into MinterTeam:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@i7495 @grkamil